Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1190#discussion_r55532861
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/topology/StatefulBoltExecutor.java ---
    @@ -148,4 +148,19 @@ private void fail(List<Tuple> tuples) {
             }
         }
     
    +    private static class AckTrackingOutputCollector extends 
AnchoringOutputCollector {
    +        private OutputCollector delegate;
    +        private List<Tuple> ackedTuples;
    +
    +        AckTrackingOutputCollector(OutputCollector delegate) {
    +            super(delegate);
    +            this.delegate = delegate;
    +            this.ackedTuples = new ArrayList<>();
    --- End diff --
    
    All access to ackedTuples should ideally be thread safe, as the 
OutputCollector could be called from a different thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to