Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1199#discussion_r55633878
  
    --- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
    @@ -124,6 +124,31 @@ public Stream parallelismHint(int hint) {
         }
     
         /**
    +     * Sets the CPU Load resource for the current node
    +     */
    +    public Stream setCPULoad(Number load) {
    --- End diff --
    
    A `Stream` should ideally have only streaming operations but it seems we 
are bringing the topology configuration into the stream api which does not look 
very clean. Cant this be part of the `TridentTopology` or passed during 
`submitTopology` ? If this should really be part of stream, can we have a 
single method like `nodeConfig(NodeConfig config)` and have all these methods 
as part of the `NodeConfig` so that we have only one extra method which is not 
really a stream operation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to