[ 
https://issues.apache.org/jira/browse/STORM-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192024#comment-15192024
 ] 

ASF GitHub Bot commented on STORM-676:
--------------------------------------

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1072#discussion_r55930081
  
    --- Diff: 
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
 ---
    @@ -0,0 +1,134 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.storm.starter.trident;
    +
    +import org.apache.storm.Config;
    +import org.apache.storm.LocalCluster;
    +import org.apache.storm.StormSubmitter;
    +import org.apache.storm.generated.StormTopology;
    +import org.apache.storm.topology.base.BaseWindowedBolt;
    +import org.apache.storm.trident.Stream;
    +import org.apache.storm.trident.TridentTopology;
    +import org.apache.storm.trident.operation.BaseAggregator;
    +import org.apache.storm.trident.operation.BaseFunction;
    +import org.apache.storm.trident.operation.Function;
    +import org.apache.storm.trident.operation.TridentCollector;
    +import org.apache.storm.trident.operation.TridentOperationContext;
    +import org.apache.storm.trident.operation.builtin.Debug;
    +import org.apache.storm.trident.testing.CountAsAggregator;
    +import org.apache.storm.trident.testing.FixedBatchSpout;
    +import org.apache.storm.trident.tuple.TridentTuple;
    +import org.apache.storm.trident.windowing.InMemoryWindowsStoreFactory;
    +import org.apache.storm.trident.windowing.WindowsStoreFactory;
    +import org.apache.storm.trident.windowing.config.SlidingCountWindow;
    +import org.apache.storm.trident.windowing.config.SlidingDurationWindow;
    +import org.apache.storm.trident.windowing.config.TumblingCountWindow;
    +import org.apache.storm.trident.windowing.config.TumblingDurationWindow;
    +import org.apache.storm.trident.windowing.config.WindowConfig;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.Values;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + *
    + */
    +public class TridentWindowingInmemoryStoreTopology {
    +    private static final Logger log = 
LoggerFactory.getLogger(TridentWindowingInmemoryStoreTopology.class);
    --- End diff --
    
    in storm we are always using capital LOG. can you please make sure this 
reflected across patch.


> Storm Trident support for sliding/tumbling windows
> --------------------------------------------------
>
>                 Key: STORM-676
>                 URL: https://issues.apache.org/jira/browse/STORM-676
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Sriharsha Chintalapani
>            Assignee: Satish Duggana
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: StormTrident_windowing_support-676.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to