[
https://issues.apache.org/jira/browse/STORM-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193270#comment-15193270
]
Robert Joseph Evans commented on STORM-1622:
--------------------------------------------
Topology jars are not supposed to depend on thing that storm has shaded.
Shading the jars is an attempt to hide it from end users and turn it into an
implementation detail. This is why we ship a dependency reduced pom which does
not list the dependencies that we shaded, so that they can pull in the
dependency themselves and package it with their topology jar. We did this so
that a topology jar is not tied to a specific storm release as much as before.
The shading went in as part of 0.10, I am -1 on undoing
https://github.com/apache/storm/commit/12fdaa01b20eb144bf18a231a05c92873c90aa09.
If you want to add in some new mappings to the hack remapping jar I am OK
with that, but I would like to see the code updated so a different warning
about not depending on shaded storm dependencies is output.
> Topology jars referring to shaded classes of older version of storm jar
> cannot be run in Storm 1.0.0
> ----------------------------------------------------------------------------------------------------
>
> Key: STORM-1622
> URL: https://issues.apache.org/jira/browse/STORM-1622
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
> This commit
> https://github.com/apache/storm/commit/12fdaa01b20eb144bf18a231a05c92873c90aa09
> changes the package names of shaded classes inside the storm. These classes
> are shipped inside the maven release of storm-core jar and can depended upon
> the topology jar. Jar built with older version of storm-core and using this
> dependency, wouldn't run on newer version of storm cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
