[ 
https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196026#comment-15196026
 ] 

ASF GitHub Bot commented on STORM-1616:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1199#discussion_r56225424
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/trident/operation/DefaultResourceDeclarer.java
 ---
    @@ -0,0 +1,62 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.trident.operation;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +import org.apache.storm.Config;
    +import org.apache.storm.utils.Utils;
    +import org.apache.storm.topology.ResourceDeclarer;
    +
    +public class DefaultResourceDeclarer implements ResourceDeclarer, 
ITridentResource {
    --- End diff --
    
    Can we make this a generic like
    
    ```
    public class DefaultResourceDeclarer<T extends DefaultResourceDeclarer> 
implements ResourceDeclarer<T>, ITridentResource {
    ```


> Add RAS API for Trident
> -----------------------
>
>                 Key: STORM-1616
>                 URL: https://issues.apache.org/jira/browse/STORM-1616
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to