Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1131#discussion_r56228825
  
    --- Diff: external/storm-kafka-client/pom.xml ---
    @@ -0,0 +1,86 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--/**
    +        * Licensed to the Apache Software Foundation (ASF) under one
    +        * or more contributor license agreements.  See the NOTICE file
    +        * distributed with this work for additional information
    +        * regarding copyright ownership.  The ASF licenses this file
    +        * to you under the Apache License, Version 2.0 (the
    +        * "License"); you may not use this file except in compliance
    +        * with the License.  You may obtain a copy of the License at
    +        *
    +        * http://www.apache.org/licenses/LICENSE-2.0
    +        *
    +        * Unless required by applicable law or agreed to in writing, 
software
    +        * distributed under the License is distributed on an "AS IS" BASIS,
    +        * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +        * See the License for the specific language governing permissions 
and
    +        * limitations under the License.
    +        */-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <artifactId>storm</artifactId>
    +        <groupId>org.apache.storm</groupId>
    +        <version>2.0.0-SNAPSHOT</version>
    +        <relativePath>../../pom.xml</relativePath>
    +    </parent>
    +
    +    <artifactId>storm-kafka-client</artifactId>
    --- End diff --
    
    In my opinion if we are going to eventually move it to storm-kafa 
eventually, lets just start out with it there now.
    
    The only downside is if someone wants to use the new spout they also get a 
dependency on all of kafka from the old spout, but that will be going away soon 
anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to