Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1108#discussion_r56236015
--- Diff: storm-core/test/clj/org/apache/storm/scheduler_test.clj ---
@@ -262,20 +262,15 @@
(deftest test-sort-slots
;; test supervisor2 has more free slots
- (is (= '(["supervisor2" 6700] ["supervisor1" 6700]
- ["supervisor2" 6701] ["supervisor1" 6701]
- ["supervisor2" 6702])
- (sort-slots [["supervisor1" 6700] ["supervisor1" 6701]
- ["supervisor2" 6700] ["supervisor2" 6701]
["supervisor2" 6702]
- ])))
+ (is (= "[supervisor2:6700, supervisor1:6700, supervisor2:6701,
supervisor1:6701, supervisor2:6702]"
+ (.toString (EvenScheduler/sortSlots [(WorkerSlot. "supervisor1"
6700) (WorkerSlot. "supervisor1" 6701)
+ (WorkerSlot. "supervisor2" 6700) (WorkerSlot.
"supervisor2" 6701) (WorkerSlot. "supervisor2" 6702)
+ ]))))
;; test supervisor3 has more free slots
- (is (= '(["supervisor3" 6700] ["supervisor2" 6700] ["supervisor1" 6700]
- ["supervisor3" 6703] ["supervisor2" 6701] ["supervisor1" 6701]
- ["supervisor3" 6702] ["supervisor2" 6702]
- ["supervisor3" 6701])
- (sort-slots [["supervisor1" 6700] ["supervisor1" 6701]
- ["supervisor2" 6700] ["supervisor2" 6701]
["supervisor2" 6702]
- ["supervisor3" 6700] ["supervisor3" 6703]
["supervisor3" 6702] ["supervisor3" 6701]
- ])))
+ (is (= "[supervisor3:6700, supervisor2:6700, supervisor1:6700,
supervisor3:6701, supervisor2:6701, supervisor1:6701, supervisor3:6702,
supervisor2:6702, supervisor3:6703]"
--- End diff --
Same here toString is not ideal for testing. It can change way too
frequently and is meant to be user consumable not machine consumable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
