Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1218#discussion_r56292072
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/metrics/BuiltinMetricsUtil.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.metrics;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.storm.Config;
+import org.apache.storm.metric.api.IMetric;
+import org.apache.storm.metric.api.IStatefulObject;
+import org.apache.storm.metric.api.StateMetric;
+import org.apache.storm.stats.BoltExecutorStats;
+import org.apache.storm.stats.SpoutExecutorStats;
+import org.apache.storm.stats.StatsUtil;
+import org.apache.storm.task.TopologyContext;
+
+public class BuiltinMetricsUtil {
+ public static BuiltinMetrics mkData(String type, Object stats) {
+ if (StatsUtil.SPOUT.equals(type)) {
+ return new BuiltinSpoutMetrics((SpoutExecutorStats) stats);
+ }
+ return new BuiltinBoltMetrics((BoltExecutorStats) stats);
+ }
+
+ public static void registerIconnectionServerMetric(Object server, Map
stormConf, TopologyContext context) {
+ if (server instanceof IStatefulObject) {
+ registerMetric("__recv-iconnection", new
StateMetric((IStatefulObject) server), stormConf, context);
+ }
+ }
+
+ public static void registerIconnectionClientMetrics(final Map
nodePort2socket, Map stormConf, TopologyContext context) {
--- End diff --
nodePort2Socket can be renamed to nodePortToSocket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
