Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-197349450 I agree with @unsleepy22 +1 except for some unneeded indentation changes (but I can look past them). The big issue now is that we need a patch for both 1.0 and for 2.0 where the stats code has moved to java.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---