[
https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197215#comment-15197215
]
ASF GitHub Bot commented on STORM-584:
--------------------------------------
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1222
Fix logging for LoggingMetricsConsumer on branch 0.10.x STORM-584
Port of #1221 to branch 0.10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DigitalPebble/storm 0.10.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1222
----
commit db5fbbde84e456de4594edf0a28e8982b5d00f12
Author: Julien Nioche <[email protected]>
Date: 2016-03-16T11:22:52Z
Fix logging for LoggingMetricsConsumer on branch 0.10.x STORM-584
----
> LoggingMetricsConsumer metrics.log file is shared by multiple topologies.
> -------------------------------------------------------------------------
>
> Key: STORM-584
> URL: https://issues.apache.org/jira/browse/STORM-584
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.9.6
> Reporter: Robert Joseph Evans
>
> The current cluster.xml file has special configuration for the
> LoggingMetricsConsumer to place it in a metrics.log file. There are several
> issues with this.
> The worker, where the LoggingMetricsConsumer is run, is configured using
> worker.xml and not cluster.xml.
> The metrics.log file is shared by all workers running on the same node. So
> if by chance we have LoggingMetricsConsumer instances running at the same
> time, the resulting log file could have a number of issues, including data
> corruption.
> This becomes much worse under security where only the first
> LoggingMetricsConsumer to run on the node will own the file, and all others
> will fail to log metrics.
> Also there is no way to access metrics.log through the ui now.
> Ideally the metrics.log file will follow a pattern similar to the worker log
> file, and have the topology name and the worker port a part of it. We also
> would want to update the logviewer daemon to allow serving up these files and
> deleting them after a specific period of time. The it would be awesome if
> the UI could detect that a logging metrics consumer is installed, and provide
> links to the metrics.log file as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
