[ 
https://issues.apache.org/jira/browse/STORM-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203447#comment-15203447
 ] 

ASF GitHub Bot commented on STORM-676:
--------------------------------------

Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1072#discussion_r56769600
  
    --- Diff: 
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
 ---
    @@ -0,0 +1,122 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.storm.starter.trident;
    +
    +import org.apache.storm.Config;
    +import org.apache.storm.LocalCluster;
    +import org.apache.storm.StormSubmitter;
    +import org.apache.storm.generated.StormTopology;
    +import org.apache.storm.hbase.trident.windowing.HBaseWindowsStoreFactory;
    +import org.apache.storm.trident.Stream;
    +import org.apache.storm.trident.TridentTopology;
    +import org.apache.storm.trident.operation.BaseFunction;
    +import org.apache.storm.trident.operation.Function;
    +import org.apache.storm.trident.operation.TridentCollector;
    +import org.apache.storm.trident.operation.TridentOperationContext;
    +import org.apache.storm.trident.operation.builtin.Debug;
    +import org.apache.storm.trident.testing.CountAsAggregator;
    +import org.apache.storm.trident.testing.FixedBatchSpout;
    +import org.apache.storm.trident.tuple.TridentTuple;
    +import org.apache.storm.trident.windowing.WindowsStoreFactory;
    +import org.apache.storm.trident.windowing.config.TumblingCountWindow;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.Values;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + *
    + */
    +public class TridentHBaseWindowingStoreTopology {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(TridentHBaseWindowingStoreTopology.class);
    +
    +    public static StormTopology buildTopology(WindowsStoreFactory 
windowsStore) throws Exception {
    +        FixedBatchSpout spout = new FixedBatchSpout(new 
Fields("sentence"), 3, new Values("the cow jumped over the moon"),
    +                new Values("the man went to the store and bought some 
candy"), new Values("four score and seven years ago"),
    +                new Values("how many apples can you eat"), new Values("to 
be or not to be the person"));
    +        spout.setCycle(true);
    +
    +        TridentTopology topology = new TridentTopology();
    +
    +        Stream stream = topology.newStream("spout1", 
spout).parallelismHint(16).each(new Fields("sentence"),
    +                new Split(), new Fields("word"))
    +                .window(TumblingCountWindow.of(1000), windowsStore, new 
Fields("word"), new CountAsAggregator(), new Fields("count"))
    +//                .tumblingTimeWindow(new BaseWindowedBolt.Duration(3, 
TimeUnit.SECONDS), windowsStore, new Fields("word"), new CountAsAggregator(), 
new Fields("count"))
    +                .each(new Fields("count"), new Debug())
    +                .each(new Fields("count"), new Echo(), new Fields("ct"));
    +
    +        return topology.build();
    +    }
    +
    +    public static class Split extends BaseFunction {
    +        @Override
    +        public void execute(TridentTuple tuple, TridentCollector 
collector) {
    +            String sentence = tuple.getString(0);
    +            for (String word : sentence.split(" ")) {
    +                collector.emit(new Values(word));
    +            }
    +        }
    +    }
    +
    +    static class Echo implements Function {
    +
    +        @Override
    +        public void execute(TridentTuple tuple, TridentCollector 
collector) {
    +            LOG.info("##########Echo.execute: " + tuple);
    +            collector.emit(tuple.getValues());
    +        }
    +
    +        @Override
    +        public void prepare(Map conf, TridentOperationContext context) {
    +
    +        }
    +
    +        @Override
    +        public void cleanup() {
    +
    +        }
    +    }
    +
    +    public static void main(String[] args) throws Exception {
    +        Config conf = new Config();
    +        conf.setMaxSpoutPending(20);
    +        conf.put(Config.TOPOLOGY_TRIDENT_WINDOWING_INMEMORY_CACHE_LIMIT, 
2);
    --- End diff --
    
    Is this a reasonable value? May be explain how should users decide what 
value to provide?


> Storm Trident support for sliding/tumbling windows
> --------------------------------------------------
>
>                 Key: STORM-676
>                 URL: https://issues.apache.org/jira/browse/STORM-676
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Sriharsha Chintalapani
>            Assignee: Satish Duggana
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: StormTrident_windowing_support-676.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to