Github user haohui commented on a diff in the pull request:
https://github.com/apache/storm/pull/1169#discussion_r56775558
--- Diff:
external/sql/storm-sql-core/src/test/org/apache/storm/sql/TestStormSql.java ---
@@ -129,4 +134,20 @@ public void testExternalNestedInvalidAccess() throws
Exception {
sql.execute(stmt, h);
Assert.assertEquals(0, values.size());
}
+
+ @Test
+ public void testExternalUdf() throws Exception {
--- End diff --
It would be a good idea to have unit tests for UDF + type conversions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
