Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1242#discussion_r56929816
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -491,7 +493,7 @@
               EVENTLOGGER-STREAM-ID
               [component-id message-id (System/currentTimeMillis) values]))))
     
    -(defmethod mk-threads :spout [executor-data task-datas initial-credentials]
    +(defmethod mk-threads :spout [executor-data task-datas initial-credentials 
throttle-on]
    --- End diff --
    
    I think this is logically wrong. Throttle-on flag is a boolean that you 
have to obtain dynamically from the executor-data in run time, not that you can 
pass in as a constant when making the spout thread at the begining.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to