Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143584
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/strategy/WindowStrategyFactory.java
---
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.storm.trident.windowing.strategy;
+
+import org.apache.storm.trident.windowing.config.WindowConfig;
+
+/**
+ *
+ */
+public final class WindowStrategyFactory {
+
+ private WindowStrategyFactory() {
+ }
+
+ /**
+ * Creates a {@code WindowStrategy} instance based on the given {@code
windowConfig}.
+ *
+ * @param windowConfig
+ * @return
+ */
+ public static <T> WindowStrategy<T> create(WindowConfig windowConfig) {
+ WindowStrategy<T> windowStrategy = null;
+ WindowConfig.Type windowType = windowConfig.getWindowType();
+ switch(windowType) {
--- End diff --
instead of switching, you can add a getWindowStrategy method in
WindowConfig and invoke windowConfig.getWindowStrategy(). That way you don't
need to maintain these enum constants and add new constants if new window
configs are added in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
