Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/1195#issuecomment-200497814
  
    By using gauges we're re-implementing stuff that coda hale does, namely 
windowed stats. Just take a look at DRPCServer.java, like I mentioned. 
    
    You can use Meters or Histograms (I don't care). But they should both allow 
you to delete a large amount of code. It should basically come down to 3-5 
lines initializing the meters/histograms. Some of the current ones will be 
combined, for instance `largestHeartbeatSize` and `averageHeartbeatSize` can be 
combined into one Histogram automatically. Just set up a Histogram and mark it 
with the heartbeat size whenever a heartbeat comes in. 
    
    Most of the work is just deleting code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to