[
https://issues.apache.org/jira/browse/STORM-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208962#comment-15208962
]
ASF GitHub Bot commented on STORM-1611:
---------------------------------------
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1195#issuecomment-200497814
By using gauges we're re-implementing stuff that coda hale does, namely
windowed stats. Just take a look at DRPCServer.java, like I mentioned.
You can use Meters or Histograms (I don't care). But they should both allow
you to delete a large amount of code. It should basically come down to 3-5
lines initializing the meters/histograms. Some of the current ones will be
combined, for instance `largestHeartbeatSize` and `averageHeartbeatSize` can be
combined into one Histogram automatically. Just set up a Histogram and mark it
with the heartbeat size whenever a heartbeat comes in.
Most of the work is just deleting code.
> port org.apache.storm.pacemaker.pacemaker to java
> -------------------------------------------------
>
> Key: STORM-1611
> URL: https://issues.apache.org/jira/browse/STORM-1611
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: John Fang
> Assignee: John Fang
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
