GitHub user sachingsachin opened a pull request:

    https://github.com/apache/storm/pull/1288

    KafkaSpout - Improve "_lostMessageCount" metric for failed tuples

    Improve "_lostMessageCount" metric if a failed offset is beyond the 
configured "_spoutConfig.maxOffsetBehind"
    
    Other small changes:
    1) Rename offset to lowestValidOffset (Avoids confusion with 
generically-named variable "offset")
    2) Move a warning to its proper place (no point warning if there are no 
omitted offsets)
    3) Improve a second warning to convey the magnitude of lost offsets.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sachingsachin/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1288
    
----
commit 53574d44fe070523ac8e83e7df02e925d86efb06
Author: Sachin Goyal <sgoyal6@l-sb8m1heg8w-m.local>
Date:   2016-04-01T00:37:40Z

    Improve "_lostMessageCount" metric if a failed offset is beyond the 
configured "_spoutConfig.maxOffsetBehind"
    
    Other small changes:
    1) Rename offset to lowestValidOffset (Avoids confusion with 
generically-named variable "offset")
    2) Move a warning to its proper place (no point warning if there are no 
omitted offsets)
    3) Improve a second warning to convey the magnitude of lost offsets.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to