[ 
https://issues.apache.org/jira/browse/STORM-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221531#comment-15221531
 ] 

ASF GitHub Bot commented on STORM-1675:
---------------------------------------

GitHub user abhishekagarwal87 opened a pull request:

    https://github.com/apache/storm/pull/1296

    STORM-1675 - Allow submitting multiple jars from the client

    The PR is not complete yet and needs some refinements. I wanted to get some 
feedback first. I tried out multiple approaches -
    1. Submitting individual jar one by one - Right now the stormjar has a 
hardcoded key so that both supervisor and nimbus can download/upload the jar. 
This becomes complicated if there is more than one jar. The keys for all the 
jars have to be passed from nimbus to supervisor. Then these keys have to be 
updated, removed, waited--upon-for-code-replication etc. 
    2. Build an app-assembly jar programmatically - It is not desired as it 
changes the internal structure of jar. which can result in unknown issues e.g. 
manifests have to be handled correctly. 
    3. Packing jars into a zip, upload it and unzip it and supervisor - This is 
the current approach. It seemed to me the cleanest approach. 
    
    I can also add an option to turn zip/unzip off for single jar topologies. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abhishekagarwal87/storm multi-jar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1296
    
----
commit 81c3a331333793ebd94bf9b9c6f376d0c7817dde
Author: Abhishek Agarwal <[email protected]>
Date:   2016-04-01T10:35:59Z

    Allow submitting multiple jars from the client

----


> Ability to submit multiple jars from client to topology
> -------------------------------------------------------
>
>                 Key: STORM-1675
>                 URL: https://issues.apache.org/jira/browse/STORM-1675
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>
> Though submitting shaded jar works in most of the cases, in some cases such 
> an ability may be very helpful. e.g. storm sql project. It currently packs 
> the classes into one jar and submits it as a single topology jar. A generic 
> capability may be helpful for other tools such as storm-sql. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to