[
https://issues.apache.org/jira/browse/STORM-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221569#comment-15221569
]
ASF GitHub Bot commented on STORM-1670:
---------------------------------------
GitHub user satishd opened a pull request:
https://github.com/apache/storm/pull/1297
STORM-1670 version store should consider only active/finished version files
and avoid throwing FNF Exception
LocalState#get(String) can throw FileNotFoundException which may result in
supervisr.clj#sync-processes which stop assigning new workers/assignments etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/satishd/storm STORM-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1297
----
commit e6a4d0f0c63bd4dfa13d9bc2016ceccff1ab4c7f
Author: Satish Duggana <[email protected]>
Date: 2016-04-01T10:59:53Z
STORM-1670 version store should consider ony active/finished version files
----
> LocalState#get(String) can throw FileNotFoundException which results in not
> removing worker heartbeats and supervisor is kind of stuck.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-1670
> URL: https://issues.apache.org/jira/browse/STORM-1670
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Satish Duggana
> Assignee: Satish Duggana
> Priority: Critical
>
> LocalState#get(String) can throw FileNotFoundException which results in not
> removing worker heartbeats and it throws Exception in
> supervisr.clj#sync-processes which stops assigning new workers/assignments.
> VersionedStore#mostRecentVersionPath() can return a file only with suffix of
> .version but the original file for a specific version may not have been there
> because .version suffix was not deleted but respective data file may have
> been deleted in earlier cleanups.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
