[
https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233367#comment-15233367
]
ASF GitHub Bot commented on STORM-1700:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1325
STORM-1700 Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
(1.x)
> NOTE: This is based on STORM-1698, PR #1323
* Users can set whitelist or blacklist to filter out metrics by name
* if none of them specified (by default), no metrics are filtered out
* how to match: substring match with regular expression
* use both ^ and $ when you want to match strictly (full string match)
* added unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1700-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1325
----
commit 2dce735bacc5eb1ff7de5ca9f161373767e4f30d
Author: Jungtaek Lim <[email protected]>
Date: 2016-04-08T04:05:00Z
STORM-1698 Asynchronous MetricsConsumerBolt
* change MetricsConsumerBolt's behavior to asynchronus manner
* to avoid bad side effect of topology
* for details please refer JIRA issue:
https://issues.apache.org/jira/browse/STORM-1698
commit ff96564282f8d3085876d885e2f3714125fff53a
Author: Jungtaek Lim <[email protected]>
Date: 2016-04-09T05:11:20Z
STORM-1700 Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
* Users can set whitelist or blacklist to filter out metrics by name
* if none of them specified (by default), no metrics are filtered out
* how to match: substring match with regular expression
* use both ^ and $ when you want to match strictly (full string match)
* added unit test
----
> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -------------------------------------------------------------
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules
> (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of
> metrics. If MetricsConsumer cannot keep up with these metrics, only way to
> keep up is increasing parallelism, which seems limited. Furthermore, some
> users don't want to care about some metrics since unintended metrics will
> fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better
> to support filter by Storm side. It will reduce the redundant works for Storm
> community.
> If we provide filter options, it would be great.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
