[
https://issues.apache.org/jira/browse/STORM-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234448#comment-15234448
]
ASF GitHub Bot commented on STORM-1701:
---------------------------------------
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/1327#discussion_r59150105
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -68,7 +69,13 @@ public void execute(Tuple tuple) {
collector.ack(tuple);
return;
}
- byte[] rowKey = this.mapper.rowKey(tuple);
+ byte[] rowKey = new byte[0];
+ try {
+ rowKey = this.mapper.rowKey(tuple);
+ } catch (ParseException e) {
+ this.collector.reportError(e);
+ this.collector.fail(tuple);
+ }
Get get = hBaseClient.constructGetRequests(rowKey,
projectionCriteria);
--- End diff --
If the `rowKey(tuple)` call throws `ParseException` should the rest of the
method be skipped too? Can it do anything useful without a valid rowkey?
> Add simple JSON mapping to storm-hbase
> --------------------------------------
>
> Key: STORM-1701
> URL: https://issues.apache.org/jira/browse/STORM-1701
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hbase
> Reporter: Kristopher Kane
> Priority: Trivial
> Fix For: 2.0.0
>
>
> storm-hbase includes a way to map Storm fields to HBase CQs. This adds a
> similar ability where a single field contains a flat JSON and the keys map to
> CQs. The flat JSON must contain the row key.
> No intention of reverse mapping from HBaseLookUp as the existing HBaseMapper
> works well for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
