[ 
https://issues.apache.org/jira/browse/STORM-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235178#comment-15235178
 ] 

ASF GitHub Bot commented on STORM-1693:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1326#discussion_r59214980
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/metric/internal/LatencyStatAndMetric.java 
---
    @@ -248,12 +248,6 @@ private synchronized void rotate(long lat, long count, 
long timeSpent, long targ
             return Utils.zeroIfNaNOrInf(((double) totalLat) / totalCount);
         }
     
    -    public void close() {
    -        if (_task != null) {
    -            _task.cancel();
    --- End diff --
    
    Here too we do need to cancel the task eventually.


> Negative counts in the UI for __metrics stream
> ----------------------------------------------
>
>                 Key: STORM-1693
>                 URL: https://issues.apache.org/jira/browse/STORM-1693
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>            Priority: Critical
>         Attachments: Screen Shot 2016-04-07 at 7.05.01 PM.png
>
>
> Metrics reported by UI are not correct. I am seeing negative counts for 
> output stats in the bolt. The same application code works fine on 0.9.6 
> version of storm. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to