[
https://issues.apache.org/jira/browse/STORM-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251232#comment-15251232
]
ASF GitHub Bot commented on STORM-1535:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1351#discussion_r60524577
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/security/HdfsSecurityUtil.java
---
@@ -40,23 +41,27 @@
public static final String STORM_USER_NAME_KEY =
"hdfs.kerberos.principal";
private static final Logger LOG =
LoggerFactory.getLogger(HdfsSecurityUtil.class);
-
+ private static AtomicBoolean isLoggedIn = new AtomicBoolean();
public static void login(Map conf, Configuration hdfsConfig) throws
IOException {
//If AutoHDFS is specified, do not attempt to login using keytabs,
only kept for backward compatibility.
if(conf.get(TOPOLOGY_AUTO_CREDENTIALS) == null ||
(!(((List)conf.get(TOPOLOGY_AUTO_CREDENTIALS)).contains(AutoHDFS.class.getName()))
&&
!(((List)conf.get(TOPOLOGY_AUTO_CREDENTIALS)).contains(AutoTGT.class.getName()))))
{
if (UserGroupInformation.isSecurityEnabled()) {
- LOG.info("Logging in using keytab as AutoHDFS is not
specified for " + TOPOLOGY_AUTO_CREDENTIALS);
- String keytab = (String) conf.get(STORM_KEYTAB_FILE_KEY);
- if (keytab != null) {
- hdfsConfig.set(STORM_KEYTAB_FILE_KEY, keytab);
- }
- String userName = (String) conf.get(STORM_USER_NAME_KEY);
- if (userName != null) {
- hdfsConfig.set(STORM_USER_NAME_KEY, userName);
+ // compareAndSet added because of
https://issues.apache.org/jira/browse/STORM-1535
+ // need to test it first during ERIE release testing since
the JIRA says "might" be and port it to apache.
--- End diff --
@priyank5485 You may want to remove this comment as it is not valid here in
apache repo.
> Storm-HDFS - When using keytab Kerberos ticket is not renewed with multiple
> bolts/executors
> -------------------------------------------------------------------------------------------
>
> Key: STORM-1535
> URL: https://issues.apache.org/jira/browse/STORM-1535
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs
> Affects Versions: 0.10.0, 0.9.5
> Reporter: Dan Bahir
> Assignee: Priyank Shah
>
> When logging in with a keytab, if the topology has more than one instance of
> an HDFS bolt then the ticket might not be automatically renewed.
> Bug has been fixed for HBase bolt, code is slightly different for HDFS bolt
> and therefore requires further investigation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
