[
https://issues.apache.org/jira/browse/STORM-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251799#comment-15251799
]
ASF GitHub Bot commented on STORM-1723:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1352#discussion_r60570256
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/ClusterConsumerExecutor.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.metric;
+
+import com.google.common.util.concurrent.MoreExecutors;
+import org.apache.storm.Config;
+import org.apache.storm.metric.api.DataPoint;
+import org.apache.storm.metric.api.IClusterMetricsConsumer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+
+public class ClusterConsumerExecutor {
+ public static final Logger LOG =
LoggerFactory.getLogger(ClusterConsumerExecutor.class);
+
+ private IClusterMetricsConsumer metricsConsumer;
+ private String consumerClassName;
+ private Object registerationArgument;
+ private ExecutorService consumerExecutorService;
+
+ public ClusterConsumerExecutor(String consumerClassName, Object
registerationArgument) {
+ this.consumerClassName = consumerClassName;
+ this.registerationArgument = registerationArgument;
--- End diff --
typo: `registerationArgument ` should be `registrationArgument `
> Introduce ClusterMetricsConsumer
> --------------------------------
>
> Key: STORM-1723
> URL: https://issues.apache.org/jira/browse/STORM-1723
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Affects Versions: 2.0.0, 1.0.1
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> NOTE: This issue is already discussed shortly. Please refer
> [here|http://mail-archives.apache.org/mod_mbox/storm-dev/201604.mbox/%3CCAF5108hDCcMKxLXKUYLReOoKkNNdgW2YudweR+mKr=1hlsl...@mail.gmail.com%3E]
> for details.
> This issue focuses to introduce ClusterMetricsConsumer and provide interface
> to let users plugin their consumers.
> ClusterMetricsConsumers will be attached to Nimbus, and leader of Nimbus will
> push cluster related metrics to ClusterMetricsConsumer.
> Requirements of ClusterMetricsConsumer are here:
> - Only leader of Nimbus should publish cluster metrics to consumer.
> - Nimbus shouldn't be affected by crashing or heavy latency on consumer.
> - Consumer should have resilient when crashing or Nimbus should take care of.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
