Github user jianbzhou commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-213211034
Hi, i am not sure if I should post a small issue here or anyone can tell me
what is the formal process to do so? thanks!
During the testing we found a small bug in
org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java(TopicPartition
doesn't implement the comparable interface), below is the fix we applied:
public Set<TopicPartition> retriableTopicPartitions() {
- final Set<TopicPartition> tps = new TreeSet<>();
+ final Set<TopicPartition> tps = new TreeSet<>(new
Comparator<TopicPartition>() {
+ @Override
+ public int compare(TopicPartition o1, TopicPartition o2) {
+ return o1.toString().compareTo(o2.toString());
+ }
+ });
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
