[ 
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253190#comment-15253190
 ] 

ASF GitHub Bot commented on STORM-822:
--------------------------------------

Github user jianbzhou commented on the pull request:

    https://github.com/apache/storm/pull/1131#issuecomment-213211034
  
    Hi, i am not sure if I should post a small issue here or anyone can tell me 
what is the formal process to do so? thanks!
    During the testing we found a small bug in 
org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java(TopicPartition
 doesn't implement the comparable interface), below is the fix we applied: 
         public Set<TopicPartition> retriableTopicPartitions() {
    -        final Set<TopicPartition> tps = new TreeSet<>();
    +        final Set<TopicPartition> tps = new TreeSet<>(new 
Comparator<TopicPartition>() {
    +            @Override
    +            public int compare(TopicPartition o1, TopicPartition o2) {
    +                return o1.toString().compareTo(o2.toString());
    +            }
    +        });


> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to 
> reduce dependencies and use long term supported kafka apis 
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-822
>                 URL: https://issues.apache.org/jira/browse/STORM-822
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Hugo Louro
>             Fix For: 1.0.0, 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to