[ 
https://issues.apache.org/jira/browse/STORM-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263810#comment-15263810
 ] 

ASF GitHub Bot commented on STORM-1746:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61552972
  
    --- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,11 @@ public static ByteBufferMessageSet 
fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition 
+ "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    Worker gets killed due to this error. It should be logged as error only. 


> Don't error log NOT_LEADER_FOR_PARTITION in KafkaUtils
> ------------------------------------------------------
>
>                 Key: STORM-1746
>                 URL: https://issues.apache.org/jira/browse/STORM-1746
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>            Priority: Minor
>
> NOT_LEADER_FOR_PARTITION may be returned in a fetch any time a partition in 
> Kafka switches leader. Since it is transient most of the time, it should be 
> downgraded to warning log level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to