Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61556517
  
    --- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,11 @@ public static ByteBufferMessageSet 
fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition 
+ "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    I see. Then we can remove this log itself since the same message is being 
logged again at 
https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java#L143.
 
    TridentKafkaSpout is swallowing up the exception. You can add the exception 
in the log there. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to