[ 
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280075#comment-15280075
 ] 

ASF GitHub Bot commented on STORM-822:
--------------------------------------

Github user jianbzhou commented on the pull request:

    https://github.com/apache/storm/pull/1131#issuecomment-218453241
  
    HI Hcml, 
    Just fyi - 
    In method doSeekRetriableTopicPartitions, we find below code:
    **kafkaConsumer.seekToEnd(rtp);    // Seek to last committed offset**
    Above code is contradictory with the comments, we replaced above line to 
below:
    **OffsetAndMetadata commitOffset = kafkaConsumer.committed(rtp);
    kafkaConsumer.seek(rtp, commitOffset.offset());    // Seek to last 
committed offset**
    Any comments please let me know. Thanks!
    
    For all above identified issues, we applied some quick and dirty fix and 
the testing is in progress, we will let you know the final testing result later.


> Kafka Spout New Consumer API
> ----------------------------
>
>                 Key: STORM-822
>                 URL: https://issues.apache.org/jira/browse/STORM-822
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Hugo Louro
>             Fix For: 1.0.0, 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to