[
https://issues.apache.org/jira/browse/STORM-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285206#comment-15285206
]
ASF GitHub Bot commented on STORM-1838:
---------------------------------------
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1419#issuecomment-219533584
@flisky can you please share the code, or at least the steps to reproduce
the scenario where this code does not work? Another alternative is that you
enable all the logging levels for us to understand what is happening. That
could should be necessary, and I am not very comfortable just removing it
without understanding what is going on.
Without that code, I believe that the scenario where a consumer rebalance
occurs, and offsets 1,2 have been hacked, but 3 is still pending, and 4, 5 have
also been acked, won't work. That code is there to cover for this scenario.
> [storm-kafka-client] the resumed OffsetEntry goes different
> -----------------------------------------------------------
>
> Key: STORM-1838
> URL: https://issues.apache.org/jira/browse/STORM-1838
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Jifeng Yin
> Fix For: 1.0.1
>
>
> There are no more new messages after consumer rejoins the group. And it turns
> out the old OffsetEntry instance kept commitOffsetsForAckedTuples failing.
> the comment "leave the acked offsets as they were to resume where it left
> off" doesn't work for me, but the ackedMsgs goes different.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
