Erik,
If we stop adding comments to JIRA there is no central place to
look at the JIRA and patch history. One has to go to github and
figure out the closed PR and see the history of the patch. Today
if I go to jira I can see all the comments and patch link as
well. At least for us this is helpful to look at what went
though the patch when a user hits a similar issue.
Thanks,
Harsha
On Mon, May 16, 2016, at 01:22 PM, Erik Weathers wrote:
> :_( I was happy for a second that the comments weren't getting added to
> JIRA. I still have not seen a convincing argument for duplicating code
> review comments into the JIRA issues.
>
> - Erik
>
> On Mon, May 16, 2016 at 11:33 AM, P. Taylor Goetz <ptgo...@gmail.com>
> wrote:
>
> > I worked with INFRA and we were able to resolve this. Unfortunately
> > comments made on github before the fix won’t be replicated to JIRA so we’ll
> > have to look at both JIRA and github for recent comments on issues.
> >
> > -Taylor
> >
> > > On May 16, 2016, at 1:48 PM, P. Taylor Goetz <ptgo...@gmail.com> wrote:
> > >
> > > Thanks for the heads up Abhishek. I’ll work with INFRA to see if we can
> > get this resolved as it is kind of disruptive.
> > >
> > > -Taylor
> > >
> > >> On May 16, 2016, at 1:18 PM, Abhishek Agarwal <abhishc...@gmail.com>
> > wrote:
> > >>
> > >> @Taylor - Looks like it didn't work. I don't see github comments getting
> > >> published to the JIRA. Example
> > >> https://issues.apache.org/jira/browse/STORM-1755
> > >> https://github.com/apache/storm/pull/1386#issuecomment-217697370 (This
> > >> didn't get published to the JIRA)
> > >>
> > >> On Fri, May 13, 2016 at 9:42 PM, P. Taylor Goetz <ptgo...@gmail.com>
> > wrote:
> > >>
> > >>> I added ASF Github Bot to the list of contributors. Hopefully that will
> > >>> fix the issue.
> > >>>
> > >>> On May 13, 2016, at 12:10 PM, P. Taylor Goetz <ptgo...@gmail.com>
> > wrote:
> > >>>
> > >>>
> > >>> On May 13, 2016, at 4:11 AM, Jungtaek Lim <kabh...@gmail.com> wrote:
> > >>>
> > >>> Now github comments are not automatically posted to JIRA, which is less
> > >>> duplicate and more quiet.
> > >>>
> > >>>
> > >>> I think this is due to the spam countermeasures, let me see if I can
> > fix
> > >>> this. This is something we want, since we also want to capture
> > comments,
> > >>> especially +1s from committers.
> > >>>
> > >>> -Taylor
> > >>>
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Regards,
> > >> Abhishek Agarwal
> > >
> >
> >
