[
https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287679#comment-15287679
]
ASF GitHub Bot commented on STORM-1842:
---------------------------------------
Github user barrywhart commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219865469
I tested with the updated storm.thrift from this pull request. It addresses
the Python Thrift issues I was encountering.
From my perspective, this change is ready for merge.
> Forward references in storm.thrift cause tooling issues
> -------------------------------------------------------
>
> Key: STORM-1842
> URL: https://issues.apache.org/jira/browse/STORM-1842
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Barry Hart
> Assignee: Jungtaek Lim
> Priority: Critical
> Attachments: ttypes.py
>
>
> In recent versions of Storm (starting with version 1.0.0, I believe),
> storm.thrift uses several types before they are declared:
> * HBPulse
> * HBRecords
> * HBNodes
> These types are used in the definition of HBMessageData.
> This causes issues with downstream tools. For example, generating Python
> wrappers for the Storm Thrift types creates a module that will not import
> successfully.
> Would it be possible to reorder this code to define the types before using
> them? This appears to be a simple change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
