Github user moesol commented on the pull request:
https://github.com/apache/storm/pull/1393#issuecomment-220727660
I think it's awesome that this change is getting in! I'll be looking out
for the next release that contains this PR.<br>
Robert Hastings, Lab SDL: 619-553-0826, Cell: 858-395-4436, Moebius:
858-455-5431x210
SIPR: hast...@spawar.navy.smil.mil
JWICS: hast...@spawar.navy.ic.gov
From: "P. Taylor Goetz" <notificati...@github.com>
To: "apache/storm" <st...@noreply.github.com>
Cc: "rhastings" <rhasti...@moesol.com>, "Mention"
<ment...@noreply.github.com>
Sent: Friday, May 20, 2016 1:03:11 PM
Subject: Re: [apache/storm] (STORM-1674) Idle KafkaSpout consumes more
bandwidth than needed (#1393)
Thanks @moesol I merged this into master, 1.x-branch and 1.0.x-branch.
Note that with 1.0.x-branch this created a conflict, as
KafkaConfig.minFetchByte had been introduced to do the same thing as your
KafkaConfig.fetchMinBytes variable. These are public variables, so they make up
part of the API.
Since 1.0.1 had already been released with the minFetchByte varibable, to
ensure backward compatibility I used the minFetchByte variable name across
branches.
While I prefer the variable name you chose, I think it's more important to
ensure backward compatibility. :)
Thanks again!
â
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
