[ 
https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299566#comment-15299566
 ] 

ASF GitHub Bot commented on STORM-1864:
---------------------------------------

Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1446#discussion_r64522988
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/hooks/SubmitterHookException.java ---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.storm.hooks;
    +
    +/**
    + * This Exception is thrown when registered {@link 
org.apache.storm.ISubmitterHook} could not be initialized or invoked.
    + */
    +public class SubmitterHookException extends RuntimeException {
    --- End diff --
    
    Maintaining backward compatibility is the main reason for this exception 
being _RuntimeException_
    Added docs at the appropriate places for this usage.


> StormSubmitter should show proper error messages for submitter hook 
> invocation.
> -------------------------------------------------------------------------------
>
>                 Key: STORM-1864
>                 URL: https://issues.apache.org/jira/browse/STORM-1864
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core, storm-hive
>            Reporter: Satish Duggana
>            Assignee: Satish Duggana
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to