[
https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305240#comment-15305240
]
ASF GitHub Bot commented on STORM-1277:
---------------------------------------
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1445#issuecomment-222297509
@abhishekagarwal87
For your Point 2, after more thoughts, I think it might be a little
difficult to move BaseExecutor into Executor. Before creating the real
executor, we need to init some context in advance i.e., ExecutorData, so that
we know whether we want a SpoutExecutor or BoltExecutor, but if we move this
into Executor as an abstract class, this will be that we are trying to create a
BaseExecutor before we know what to create exactly.
I think it's better to rename Executor class to be ExecutorMaker or
ExecutorUtil or something, what do you think?
> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
> Key: STORM-1277
> URL: https://issues.apache.org/jira/browse/STORM-1277
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Cody
> Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task
> kind of. Tasks and executors are combined in jstorm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
