Github user ptgoetz commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1331#discussion_r66318510
  
    --- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/SpoutConfig.java ---
    @@ -37,6 +37,8 @@
         public long retryInitialDelayMs = 0;
         public double retryDelayMultiplier = 1.0;
         public long retryDelayMaxMs = 60 * 1000;
    +    public int retryLimit = Integer.MAX_VALUE;
    --- End diff --
    
    This is probably an unlikely edge case, but theoretically possible: If a 
tuple is retried `Integer.MAX_VALUE` times, it will be dropped.
    
    To truly turn off retry limits, I would suggest setting this to `-1` and 
adding logic to check for that in logic that checks to see if the retry limit 
has been reached.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to