Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1500#discussion_r67634689
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java ---
@@ -56,7 +56,11 @@ public T setNumTasks(Number val) {
@Override
public T setMemoryLoad(Number onHeap) {
- return setMemoryLoad(onHeap,
Utils.getDouble(conf.get(Config.TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB)));
+ if (onHeap != null) {
+ onHeap = onHeap.doubleValue();
+ return
addConfiguration(Config.TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB, onHeap);
+ }
+ return null;
--- End diff --
Minor: This can be replaced with `setMemoryLoad(onHeap, null)` but I'm OK
to split two methods completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
