Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280207
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -179,8 +188,13 @@ public BoltDeclarer setBolt(String id, IRichBolt bolt)
throws IllegalArgumentExc
public BoltDeclarer setBolt(String id, IRichBolt bolt, Number
parallelism_hint) throws IllegalArgumentException {
validateUnusedId(id);
initCommon(id, bolt, parallelism_hint);
- _bolts.put(id, bolt);
- return new BoltGetter(id);
+
+ if (_bolts.containsKey(id)) {
+ throw new IllegalArgumentException("Bolt " + id + " have
existed");
--- End diff --
Can we say `"duplicate bolt id found " + id` instead? I think it sounds a
bit cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
