Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1535#discussion_r69408836
--- Diff:
storm-core/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -219,6 +219,8 @@ public void stateChanged(CuratorFramework
curatorFramework, ConnectionState conn
LOG.info("Connection state listener invoked, zookeeper
connection state has changed to {}", connectionState);
if (connectionState.equals(ConnectionState.RECONNECTED)) {
LOG.info("Connection state has changed to reconnected
so setting nimbuses entry one more time");
+ // explicit delete for ephmeral node to ensure this
session creates the entry.
+
stateStorage.delete_node(ClusterUtils.nimbusPath(nimbusId));
--- End diff --
Aren't we using ephemeral node for this? If not I think we should do that
no? Instead of manually deleting the node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
