[
https://issues.apache.org/jira/browse/STORM-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364357#comment-15364357
]
ASF GitHub Bot commented on STORM-1945:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1541
STORM-1945 Fix NPE bugs on topology spout lag for storm-kafka-monitor (1.x)
PR for master: #1540
* Fix several spots which are throwing NPE on TopologySpoutLag
* Use a trick to get classname of Spout without requiring storm-kafka and
storm-kafka-client
* Move storm-kafka-monitor jar to toollib directory
* since jars in extlib are added to worker classpath which we don't want
for this jar
@priyank5485 @harshach Please take a look and comment. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1945-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1541
----
commit 224f542d539406297f84947aed33a404b73798d7
Author: Jungtaek Lim <[email protected]>
Date: 2016-07-06T13:49:46Z
STORM-1945 Fix NPE bugs on topology spout lag for storm-kafka-monitor
* Fix several spots which are throwing NPE on TopologySpoutLag
* Use a trick to get classname of Spout without requiring storm-kafka and
storm-kafka-client
* Move storm-kafka-monitor jar to toollib directory
* since jars in extlib are added to worker classpath which we don't want
for this jar
----
> Internal Server Error shown on topology page for topology using KafkaSpout
> --------------------------------------------------------------------------
>
> Key: STORM-1945
> URL: https://issues.apache.org/jira/browse/STORM-1945
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-ui
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
> Attachments: Screen Shot 2016-07-06 at 4.25.41 PM.png
>
>
> When opening topology page which uses old storm-kafka Spout, page shows
> Internal Server Error on bottom side.
> And REST API /api/v1/topology/:topology/lag also shows Internal Server Error.
> Its errorMessage is describing NPE, but stack track gives less help since
> it's already within catch statement so we can't trace why origin exception is
> thrown by only looking at errorMessage. And there's no error message on ui
> log file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
