Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1445#discussion_r70193530
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -179,23 +180,22 @@ public BuiltinMetrics getBuiltInMetrics() {
private TopologyContext mkTopologyContext(StormTopology topology)
throws IOException {
Map conf = (Map) workerData.get("conf");
return new TopologyContext(
- topology,
- (Map) workerData.get("storm-conf"),
- (Map<Integer, String>) workerData.get("task->component"),
- (Map<String, List<Integer>>)
workerData.get("component->sorted-tasks"),
- (Map<String, Map<String, Fields>>)
workerData.get("component->stream->fields"),
- (String) workerData.get("storm-id"),
-
ConfigUtils.supervisorStormResourcesPath(ConfigUtils.supervisorStormDistRoot(conf,
(String) workerData.get("storm-id"))),
- ConfigUtils.workerPidsRoot(conf, (String)
workerData.get("worker-id")),
- taskId,
- (Integer) workerData.get("port"),
- (List<Integer>) workerData.get("task-ids"),
- (Map<String, Object>)
workerData.get("default-shared-resources"),
- (Map<String, Object>) workerData.get("user-shared-resources"),
- (Map<String, Object>) executorData.get("shared-executor-data"),
- (Map<Integer, Map<Integer, Map<String, IMetric>>>)
executorData.get("interval->task->metric-registry"),
- (clojure.lang.Atom)
executorData.get("open-or-prepare-was-called?")
- );
+ topology,
+ (Map) workerData.get("storm-conf"),
--- End diff --
can we move these strings into final String at the top level. I prefer if
we add a file ExecutorDataConstants and all these there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
