Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1526#discussion_r70251081
--- Diff: storm-core/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -47,6 +50,8 @@
private String[] _command;
private Map<String, String> env = new HashMap<>();
private ShellProcess _process;
+ private volatile boolean _running = true;
+ private volatile Throwable _exception;
--- End diff --
nit: this is only ever set to a RuntimeException already, and then it is
wrapped in a RuntimeException. It might be nice to just have it be a
RuntimeException to begin with and then we can skip the wrapping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
