[
https://issues.apache.org/jira/browse/STORM-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370691#comment-15370691
]
ASF GitHub Bot commented on STORM-1928:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1526#discussion_r70251081
--- Diff: storm-core/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -47,6 +50,8 @@
private String[] _command;
private Map<String, String> env = new HashMap<>();
private ShellProcess _process;
+ private volatile boolean _running = true;
+ private volatile Throwable _exception;
--- End diff --
nit: this is only ever set to a RuntimeException already, and then it is
wrapped in a RuntimeException. It might be nice to just have it be a
RuntimeException to begin with and then we can skip the wrapping.
> ShellSpout should check heartbeat while ShellSpout is waiting for subprocess
> to sync
> ------------------------------------------------------------------------------------
>
> Key: STORM-1928
> URL: https://issues.apache.org/jira/browse/STORM-1928
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-multilang
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> It affects Storm releases which are greater than 0.9.3 so I didn't set affect
> version/s. All version lines are affected.
> When nextTuple is not calling at any chances (max spout pending, backpressure
> introduced at 1.0.0, and so on) multi-lang spout don't receive any message
> from ShellSpout, thus no messages from multi-lang spout side. (because
> multilang spout and ShellSpout communicates like ping-pong, unlike multilang
> bolt and ShellBolt)
> In result, no heartbeat is being marked, and finally raises subprocess
> heartbeat timeout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
