Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1560#discussion_r70800924
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/metric/util/DataPointPopulator.java ---
    @@ -0,0 +1,61 @@
    +package org.apache.storm.metric.util;
    +
    +import org.apache.storm.metric.api.IMetricsConsumer;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Map;
    +
    +public class DataPointPopulator implements Serializable {
    --- End diff --
    
    Yes `expand` would be better. I was not sure which word is good to 
represent the behavior. We can replace all `populate` to `expand`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to