[
https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377044#comment-15377044
]
ASF GitHub Bot commented on STORM-1876:
---------------------------------------
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1482#discussion_r70818175
--- Diff: pom.xml ---
@@ -258,6 +258,12 @@
<calcite.version>1.4.0-incubating</calcite.version>
<jackson.version>2.6.3</jackson.version>
<maven-surefire.version>2.18.1</maven-surefire.version>
+
+ <!-- Kafka version used by old kafka spout code -->
+ <storm.kafka.version>0.8.2.1</storm.kafka.version>
+ <storm.kafka.artifact.id>kafka_2.10</storm.kafka.artifact.id>
+
+ <!-- kafka version used by new kafka spout code -->
--- End diff --
@abhishekagarwal87 can the property names be a bit more consistent?
A suggestion would be to prefix the properties used by `storm.kafka.client`.
> Provide option to build storm-kafka against different kafka clients
> -------------------------------------------------------------------
>
> Key: STORM-1876
> URL: https://issues.apache.org/jira/browse/STORM-1876
> Project: Apache Storm
> Issue Type: Improvement
> Components: documentation, storm-kafka
> Reporter: Abhishek Agarwal
> Assignee: Abhishek Agarwal
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
