Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/1566#discussion_r71151878
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/sync/CountSyncPolicy.java
---
@@ -26,7 +26,7 @@
* have been processed.
*/
public class CountSyncPolicy implements SyncPolicy {
- private int count;
+ private final int count;
--- End diff --
Great catch to make that final. I would be +1 on that change in a separate
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
