[
https://issues.apache.org/jira/browse/STORM-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393759#comment-15393759
]
ASF GitHub Bot commented on STORM-1995:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1593#discussion_r72244414
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1793,16 +1793,16 @@
(.mark nimbus:num-downloadChunk-calls)
(check-authorization! nimbus nil nil "fileDownload")
(let [downloaders (:downloaders nimbus)
- ^BufferFileInputStream is (.get downloaders id)]
+ ^BufferInputStream is (.get downloaders id)]
--- End diff --
Is there a reason to change type hint class name?
http://storm.apache.org/releases/1.0.0/javadocs/org/apache/storm/utils/BufferFileInputStream.html
BufferFileInputStream is not a "is-a" BufferInputStream, and it also has
close() method itself.
> downloadChunk in nimbus.clj should close the input stream
> ---------------------------------------------------------
>
> Key: STORM-1995
> URL: https://issues.apache.org/jira/browse/STORM-1995
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0, 1.0.0, 2.0.0
> Reporter: Alessandro Bellina
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
