Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1593#discussion_r72244414
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1793,16 +1793,16 @@
(.mark nimbus:num-downloadChunk-calls)
(check-authorization! nimbus nil nil "fileDownload")
(let [downloaders (:downloaders nimbus)
- ^BufferFileInputStream is (.get downloaders id)]
+ ^BufferInputStream is (.get downloaders id)]
--- End diff --
Is there a reason to change type hint class name?
http://storm.apache.org/releases/1.0.0/javadocs/org/apache/storm/utils/BufferFileInputStream.html
BufferFileInputStream is not a "is-a" BufferInputStream, and it also has
close() method itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
