Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/1587
  
    @darionyaphet can you please clarify why this patch is needed? In my 
understanding it shouldn't be necessary to have any logic for auto commit 
interval. If one wishes to set the auto commit interval, one can do so using 
the kafka properties `autocommit.interval.ms` and `autocommit.enable`. These 
properties will then be passed the `KafkaConsumer` 
[here](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L350)
    
    The [commit 
timer](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L111)
 is only used when in non auto commit mode. The 500 is only the initial delay. 
One can make this initial delay configurable, but it may not be of extreme 
importance to do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to