Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1583#discussion_r73574871
--- Diff:
external/storm-druid/src/main/java/org/apache/storm/druid/bolt/DruidConfig.java
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.storm.druid.bolt;
+
+import com.metamx.tranquility.tranquilizer.Tranquilizer;
+
+import java.io.Serializable;
+
+public class DruidConfig implements Serializable {
+
+ //Tranquilizer configs for DruidBeamBolt
+ private int maxBatchSize;
+ private int maxPendingBatches;
+ private long lingerMillis;
+ private boolean blockOnFull;
+ private boolean enableDiscardStream;
+ private String discardStreamId;
+
+ public int getMaxBatchSize() {
+ return maxBatchSize;
+ }
+
+ public int getMaxPendingBatches() {
+ return maxPendingBatches;
+ }
+
+ public long getLingerMillis() {
+ return lingerMillis;
+ }
+
+ public boolean isBlockOnFull() {
+ return blockOnFull;
+ }
+
+ public boolean isEnableDiscardStream() {
+ return enableDiscardStream;
+ }
+
+ public String getDiscardStreamId() {
+ return discardStreamId;
+ }
+
+ private DruidConfig(Builder builder) {
+ this.maxBatchSize = builder.maxBatchSize;
+ this.maxPendingBatches = builder.maxPendingBatches;
+ this.lingerMillis = builder.lingerMillis;
+ this.blockOnFull = builder.blockOnFull;
+ this.enableDiscardStream = builder.enableDiscardStream;
+ this.discardStreamId = builder.discardStreamId;
+ }
+
+ public static DruidConfig.Builder newBuilder() {
+ return new Builder();
+ }
+
+ public static class Builder {
+ private int maxBatchSize = Tranquilizer.DefaultMaxBatchSize();
+ private int maxPendingBatches =
Tranquilizer.DefaultMaxPendingBatches();
+ private long lingerMillis = Tranquilizer.DefaultLingerMillis();
+ private boolean blockOnFull = Tranquilizer.DefaultBlockOnFull();
+ private boolean enableDiscardStream = false;
+ private String discardStreamId ="druid-discard-stream";
--- End diff --
"druid-discard-stream" can be declared as a public constant like
DEFAULT_DISCARD_STREAM_ID in `DruidConfig` class, so that users can use thos
stream id while building the topology.
I prefer to remove `enableDiscardStream` and have only `discardStreamId`
which should be given by the user if user wants discarded events to be
forwarded to that stream. This API makes it simpler to set only the
discardStreamId.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
